Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Add path to video #673

Merged
merged 7 commits into from
Jan 13, 2025
Merged

[Improvement] Add path to video #673

merged 7 commits into from
Jan 13, 2025

Conversation

mattamon
Copy link
Contributor

@mattamon mattamon commented Jan 13, 2025

Changes in this pull request

Resolves #671
Resolves #672

Additional info

Adding normalizer interface to video adapter to add path info

@mattamon mattamon marked this pull request as draft January 13, 2025 07:39
@mattamon mattamon requested a review from lukmzig January 13, 2025 10:18
@mattamon mattamon marked this pull request as ready for review January 13, 2025 10:18
@mattamon
Copy link
Contributor Author

@markus-moser mabye we should talk about where to put the extra info again, since it seems to be different for different types

Copy link
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦭

@mattamon mattamon merged commit 4d769cf into 1.x Jan 13, 2025
12 checks passed
@mattamon mattamon deleted the 671-add-path branch January 13, 2025 11:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants